Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend returns null in DestructionListItemReview for the zaak field [Backend/Frontend] #378

Closed
4 tasks done
SilviaAmAm opened this issue Sep 20, 2024 · 0 comments · Fixed by #379
Closed
4 tasks done
Assignees
Labels
bug Something isn't working

Comments

@SilviaAmAm
Copy link
Collaborator

SilviaAmAm commented Sep 20, 2024

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258/backlog?selectedIssue=PZ-3969

The backend returns null if the zaak has been deleted. (https://github.com/maykinmedia/open-archiefbeheer/blob/main/backend/src/openarchiefbeheer/destruction/api/serializers.py#L473)

The helptext says differently: https://github.com/maykinmedia/open-archiefbeheer/blob/main/backend/src/openarchiefbeheer/destruction/api/serializers.py#L459

The api docs also need fixing because they don't say that the zaak field can be null.

Frontend needs fixing because it doesn't handle a zaak being deleted (not sure what we should do about this)

This currently breaks the test environment. Normally zaken shouldn't be deleted outside of OAB, but this still happens so we need to make sure that this scenario is handled without breaking

Todo

Backend

  • Fix helptext
  • Fix api docs

Frontend

  • Update types
  • Dont crash if zaak is null
@SilviaAmAm SilviaAmAm added the bug Something isn't working label Sep 20, 2024
@SilviaAmAm SilviaAmAm self-assigned this Sep 20, 2024
SilviaAmAm added a commit that referenced this issue Sep 20, 2024
SilviaAmAm added a commit that referenced this issue Sep 20, 2024
Whenever a zaak has been removed by some other entity. This could be in
the admin or directly in openzaak.
SilviaAmAm added a commit that referenced this issue Sep 23, 2024
SilviaAmAm added a commit that referenced this issue Sep 23, 2024
Whenever a zaak has been removed by some other entity. This could be in
the admin or directly in openzaak.
SilviaAmAm added a commit that referenced this issue Sep 26, 2024
SilviaAmAm added a commit that referenced this issue Sep 26, 2024
Whenever a zaak has been removed by some other entity. This could be in
the admin or directly in openzaak.
SilviaAmAm added a commit that referenced this issue Sep 26, 2024
Whenever a zaak has been removed by some other entity. This could be in
the admin or directly in openzaak.
SilviaAmAm added a commit that referenced this issue Sep 26, 2024
[#378] Prevent crash if reviewItem has zaak = null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant