Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/marker-icon.png in wrong location (?) #751

Open
sjoerdie opened this issue Aug 30, 2023 · 4 comments
Open

/marker-icon.png in wrong location (?) #751

sjoerdie opened this issue Aug 30, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@sjoerdie
Copy link
Contributor

sjoerdie commented Aug 30, 2023

Describe the bug

marker-icon.png and marker-shadow.png in wrong location resulting in 404 on the little map view and no marker shown.

To Reproduce

Steps to reproduce the behavior:
image

404 - static/bundles/images/marker-icon.png/

/app/static/bundles$ mkdir images
/app/static/bundles$ cp marker-icon.png marker-shadow.png images/

Refresh page:
image

Expected behavior

image

@sjoerdie sjoerdie added the bug Something isn't working label Aug 30, 2023
@sjoerdie
Copy link
Contributor Author

Still not working version v1.11.6 @alextreme Thinking about switching to WP, status?

@alextreme
Copy link
Member

@sjoerdie if you can fix this manually, it should be easy to fix in the Dockerfile right?

@sjoerdie
Copy link
Contributor Author

@alextreme , sure symlinks ftw, but this wont be viable for k8s environments. I will have a look at the docker build.

@joeribekker
Copy link
Member

joeribekker commented Aug 2, 2024

In Open Forms we collect these statics using the Django configuration:

https://github.com/open-formulieren/open-forms/blob/a6d311d0b905197e3b914490a0719202840b5d57/src/openforms/conf/base.py#L318-L327

# Additional locations of static files
STATICFILES_DIRS = [
    os.path.join(DJANGO_PROJECT_DIR, "static"),
    # font-awesome fonts
    (
        "fonts",
        os.path.join(
            BASE_DIR, "node_modules", "@fortawesome", "fontawesome-free", "webfonts"
        ),
    ),
]

Instead of the custom npm collect command used in OIP:

"collect": "cp -r node_modules/leaflet/dist/images src/open_inwoner/static/bundles && cp -r node_modules/material-icons/iconfont/*.woff src/open_inwoner/static/bundles && cp -r node_modules/material-icons/iconfont/*.woff2 src/open_inwoner/static/bundles && cp -r node_modules/@fortawesome/fontawesome-free/webfonts src/open_inwoner/static/",

I guess we can move to the Open Forms method (probably needs some leaflet setting as well) or adjust the collect command above to copy it into images.

@joeribekker joeribekker assigned swrichards and unassigned alextreme Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants