Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 4.2 #130

Closed
11 of 30 tasks
sergei-maertens opened this issue Jan 9, 2024 · 1 comment
Closed
11 of 30 tasks

Upgrade to Django 4.2 #130

sergei-maertens opened this issue Jan 9, 2024 · 1 comment

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Jan 9, 2024

Checklist to prepare the Django 4.2 LTS upgrade

3rd party packages to verify/make compatible

  • commonground-api-common - needs 4.2 support, and depends on drf-yasg etc. which is problematic
  • django-admin-index - ok
  • django-axes
    • version is okay
    • however, it is not specified as django-axes[ipware] so ipware is not pulled in, yet there are settings referring to ipware
    • possibly the reverse proxy setup is broken to determine the IP address because of this
    • it also uses legacy django axes settings like AXES_LOCK_OUT_BY_COMBINATION_USER_AND_IP
    • might just not be working properly at all
  • django-better-admin-arrayfield -> needs to be replaced, see Replace django-better-admin-arrayfield open-formulieren/open-forms#3737 for the involved changes
  • django-cors-headers - ok
  • django-db-logger - uncertain, does not appear to be tested on Django newer than 3.2 but latest release was end of 2023
  • django-loose-fk - no support, but seems to be scheduled for removal in ➖ [#124] removed django loose fk and the contactgegevens api endpoint. #128
  • django-markup - ok
  • django-redis - ok
  • django-rosetta - ok
  • djangorestframework - 3.14 added support for Django 4.1, 4.2 should work too (according to Github)
    • this also massively affects drf-yasg, which is being removed in favour of spectacular in Switch from yasg to spectacular #120
    • switch to spectacular may upgrade this from 3.12 to 3.14
  • elastic-apm - ok
  • mozilla-django-oidc-db - requires v0.14.0, see also ⬆️ [#126] update oidc-db #129
  • psycopg2 - current version is supported, upgrading to psycopg 3 is viable though
  • sentry_sdk - ok
  • zgw-consumers - ok

3rd party packages (planned) to be dropped?

  • click - doesn't seem to be used anywhere
  • jq - doesn't seem to be used anywhere
  • jsonschema - doesn't seem to be used anywhere
  • dictdiffer - doesn't seem to be used anywhere
  • python-dateutil - doesn't seem to be used anywhere
  • requests - used by third party packages, but no direct usage -> can be removed from base.in
  • requests-cache - doesn't seem to be used anywhere
  • self-certifi - doesn't seem to be used
  • bleach - doesn't seem to be used
  • django-extra-views - doesn't seem to be used
  • django-log-outgoing-requests - ok but doesn't seem to be used
  • django-sniplates - dead code only it seems

Open Klant itself

@stevenbal
Copy link
Collaborator

upgrade was done in #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants