Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use all expand options with partijen endpoint generated by OpenAPI #216

Open
hsiliev opened this issue Aug 1, 2024 · 1 comment
Labels
bug Something isn't working owner: dimpact triage

Comments

@hsiliev
Copy link

hsiliev commented Aug 1, 2024

Product versie / Product version

2.1

Omschrijf het probleem / Describe the bug

Recomended approach to fetch kontact with BSN in #138 does not seem to work as intended with generated OpenAPI models and client as ExpandPartijAllOfExpand class uses List<Betrokkene> that does not have expanded hadKlantcontact but only foreign keys.

Stappen om te reproduceren / Steps to reproduce

  1. Generate Java OpenAPI models and client
  2. Fix issues with wrong assignments of List in Partij and ExpandPartij
  3. Request Partij with nummer and expand "betrokkenen, betrokkenen.hadKlantcontact"
  4. The response does not contain expanded klantcontact

Verwacht gedrag / Expected behavior

ExpandBetrokkenen* is instead documented and used in ExpandPartijAllOfExpand

@hsiliev hsiliev added bug Something isn't working triage labels Aug 1, 2024
@hsiliev hsiliev changed the title Cannot use expand in Cannot use all expand options with partijen endpoint generated by OpenAPI Aug 1, 2024
@joeribekker
Copy link
Member

joeribekker commented Aug 5, 2024

Karin (Dimpact) needs to find budget for this. If this is an issue with the client generation tools, then we're not going to fix it. If it's an issue in the API spec, we can fix it if budget allows it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working owner: dimpact triage
Projects
Status: Triage
Development

No branches or pull requests

3 participants