Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: install step installs in C:\ #73

Open
nidefawl opened this issue Feb 5, 2022 · 0 comments
Open

Windows: install step installs in C:\ #73

nidefawl opened this issue Feb 5, 2022 · 0 comments

Comments

@nidefawl
Copy link

nidefawl commented Feb 5, 2022

Right now the install step on windows copies files to the root of your file system.

CMAKE_INSTALL_PREFIX is ignored for all files but the lib.
That is because CMAKE_INSTALL_* variables are empty.

This has to do with:

kissfft/CMakeLists.txt

Lines 104 to 110 in 8f47a67

#
# Add GNUInstallDirs for GNU infrastructure before target)include_directories
#
if(CMAKE_SYSTEM_NAME MATCHES "^(Linux|kFreeBSD|GNU)$" AND NOT CMAKE_CROSSCOMPILING)
include(GNUInstallDirs)
endif()

GNUInstallDirs should be included unconditionally. That is what most projects do. See glfw, portaudio, SQLiteCPP.

Otherwise one cannot use the install step on windows.

myd7349 added a commit to myd7349/kissfft that referenced this issue May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant