-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request for Arduino Support #76
Comments
I saw your fork. Please rename IGNORE_ARDUINO_CONFIG to a more project-specific name like KISSFFT_IGNORE_ARDUINO_CONFIG. |
... and putting yourself as the author discredits Mark's invaluable work. |
Done, but I did not get any answer from mborgerding, so I did not submit any pull request. |
Yeah, the support seems to be abandoned, as I've also seen another PR here that I wanted to be merged. Anyhow, I linked your library against a copy-pasted kissfft lib from this project and it worked out fine. |
Cool, my major goal was to be able to provide some alternative implementations in my Arduino Audio Tools, so that we can use one common API. You might also have a look at esp-dsp from Espressif... |
Actually, I had a look at your audio tools repo a few months ago when searching for a simple solution to save audio from INMP441. I hadn't noticed that you also provide FFT support and even some benches. So AudioESP32FFT appears as the winner, doesn't it? That's interesting that it supports both ARM and ESP platforms... I may have a closer look. Ah, I should have read it to the end:
Got it. |
I was wondering if you would accept a pull request to add Arduino Support which contains the following changes
With these changes the project can be used as Arduino library...
The text was updated successfully, but these errors were encountered: