Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for Arduino Support #76

Open
pschatzmann opened this issue Apr 19, 2022 · 6 comments
Open

Pull Request for Arduino Support #76

pschatzmann opened this issue Apr 19, 2022 · 6 comments

Comments

@pschatzmann
Copy link

pschatzmann commented Apr 19, 2022

I was wondering if you would accept a pull request to add Arduino Support which contains the following changes

  • new file library.properties in the root directory.
  • new file kiss_arduino_config.h in the root directory where we can define FIXED_POINT.
  • the following change in kiss_fft.h to use the configuration
#if defined(ARDUINO) && !defined(IGNORE_ARDUINO_CONFIG)
#include "kiss_arduino_config.h"
#endif

With these changes the project can be used as Arduino library...

@dizcza
Copy link

dizcza commented Apr 11, 2023

I saw your fork. Please rename IGNORE_ARDUINO_CONFIG to a more project-specific name like KISSFFT_IGNORE_ARDUINO_CONFIG.

@dizcza
Copy link

dizcza commented Apr 12, 2023

... and putting yourself as the author discredits Mark's invaluable work.

@pschatzmann
Copy link
Author

pschatzmann commented Apr 12, 2023

Done, but I did not get any answer from mborgerding, so I did not submit any pull request.
I planned to update library.properties after getting an answer, which unfortunately never happend.

@dizcza
Copy link

dizcza commented Apr 12, 2023

Yeah, the support seems to be abandoned, as I've also seen another PR here that I wanted to be merged.

Anyhow, I linked your library against a copy-pasted kissfft lib from this project and it worked out fine.

@pschatzmann
Copy link
Author

pschatzmann commented Apr 12, 2023

Cool, my major goal was to be able to provide some alternative implementations in my Arduino Audio Tools, so that we can use one common API. You might also have a look at esp-dsp from Espressif...

@dizcza
Copy link

dizcza commented Apr 12, 2023

Actually, I had a look at your audio tools repo a few months ago when searching for a simple solution to save audio from INMP441. I hadn't noticed that you also provide FFT support and even some benches.

So AudioESP32FFT appears as the winner, doesn't it? That's interesting that it supports both ARM and ESP platforms... I may have a closer look.

Ah, I should have read it to the end:

AudioRealFFT seems to perform better, with bigger values!

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants