You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I 'd like to refactor server.js a bit for use directly in node.
That's a good idea.
My proposal is to move the CLI bits into bin/cli.js and make server.js the entry point.
Keep in mind there is both client and server CLI inside reggie package. For the sake of consistency, both client and server CLI should be moved to bin (although you don't have to refactor the client code to be usable on it's own).
Maybe move to bin/server-cli.js and bin/client-cli.js?
I was about to suggest moving server.js to lib/server.js, but then realised the current file structure is better, as the developer can write require('reggie/server') and require('reggie/client').
I'd like to refactor
server.js
a bit for use directly in node. My proposal is to move the CLI bits intobin/cli.js
and makeserver.js
the entry point.Let me know if you have a better approach, or are unlikely to accept a patch that includes these changes.
The text was updated successfully, but these errors were encountered: