Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Icon should be next to text #1455

Open
Loewe111 opened this issue Sep 10, 2023 · 6 comments
Open

Button Icon should be next to text #1455

Loewe111 opened this issue Sep 10, 2023 · 6 comments

Comments

@Loewe111
Copy link

Describe the bug
If you set an icon on a button its just applied like a background ( see first image) , it would make more sense to place it next to the text

current behavior:

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Virtual Console'
  2. Create a button with text
  3. Set an icon (using the context menu)
  4. See error

Expected behavior
The icon should be placed next to the text (preferably on the left) like in the second image

Screenshots
current
image 1

expected
image 2

Desktop (please complete the following information):

  • OS: Windows
  • QLC+ Version: 4.12.7
@mcallegari
Copy link
Owner

This is as designed: a text with a background image.
QLC+ doesn't know you're setting an icon and doesn't know you want it aligned on the right (what if someone wants it to be aligned on the left? top-left? bottom-left? bottom-right? etc..)
I suggest to create background images as you prefer and apply only that

@Loewe111
Copy link
Author

Loewe111 commented Sep 10, 2023

When i right click on a button i have two options, background and symbol
grafik

It seems like they aren't the same thing, because if i set a symbol i am able to select svg, which i am not able to do with a background. They also have different shortcuts, so I assumed they are two different things.

Edit: Screenshot with language set to english
grafik

@mcallegari mcallegari reopened this Sep 11, 2023
@mcallegari
Copy link
Owner

OK, I checked and you're right.
I totally forgot about that feature!
Drawing the icon beside text is not feasible. Text is center aligned and wrapping words.
I propose to draw a custom icon on the top left corner of the button.
In this way you can have flashing icon (top right) + custom icon (top left)
Sounds good?

@Loewe111
Copy link
Author

Thats a sounds good, i assume the image would be scaled to a fixed size, right?

@mcallegari
Copy link
Owner

That's the idea but I'm still thinking about it.
I believe such change can break existing consoles like this, where they use gobos as icons

Screenshot_20230911_124143

@Loewe111
Copy link
Author

Im not sure if that would be possible to implement, but maybe converting the icons to background images with the new version could work

(i dont know if the qlc+ version is stored in the project file)
meaning if the version is less than version ... just convert them
i havent really looked at the source code, so i dont know how and wheter that can be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants