Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mark render function renderMark should be in documentation #30

Open
xJkit opened this issue May 26, 2021 · 1 comment
Open

Custom mark render function renderMark should be in documentation #30

xJkit opened this issue May 26, 2021 · 1 comment

Comments

@xJkit
Copy link

xJkit commented May 26, 2021

Thanks for this awesome library!

I meant to do some customization on the mark UI and just forked this library. I found out that there is a custom render function :

renderMark={props => (
                <mark
                  key={props.key}
                  onClick={() => props.onClick({start: props.start, end: props.end})}
                >
                  {props.content} [{props.tag}]
                </mark>
              )}

It is very useful for further customization, and it would be very nice to demo this example on the documentation.

Thanks a lot! Sincerely.

@xJkit xJkit changed the title Custom mark render function renderMark should be in documentation Custom mark render function renderMark should be in documentation May 26, 2021
@xJkit
Copy link
Author

xJkit commented May 27, 2021

After digging into the code base, I found out only the TokenAnnotation has the renderMark api.

Is there any plan to migrate this feature to the TextAnnotation component? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant