LocaleCookieRedirect throws exception when returning file response

[ridea-co]

If LocaleCookieRedirect is added to the Kernel, it throws exception when returning BinaryFileResponse, which does not have "withCookie" method at line 30

Current work around :

1. Create a new class by copy & paste LocaleCookieRedirect
2. Check and bypass if withCookie method does not exist
3. Replace LocaleCookieRedirect with the newly created class in Kernel.php

        if (\count($params) > 0 && app('laravellocalization')->checkLocaleInSupportedLocales($params[0])) {
            $response = $next($request);

            if (method_exists($response, 'withCookie')) {
                return $response->withCookie(cookie()->forever('locale', $params[0]));
            } else {
                return $response;
            } // end of if

        } // end of if

[ijaureguialzo]

Hello @ridea-co, I was having this same issue and found that if you disable the middleware for that specific route, everything works again:

Route::get('/tutor/export', 'TutorController@export')
    ->withoutMiddleware('localeCookieRedirect')
    ->name('tutor.export');

[iwasherefirst2]

@ridea-co yes your right. BinaryFileResponse does not have a withCookie method.
Instead of a if-else, we should just use $response->headers->set(...) because this works for BinaryFileResponse aswell for the default Laravel repsonse.

[mgralikowski]

Another clean workaround is using config:
'urlsIgnored' => ['*/download']
All routes (urls) are excluded.