Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to cleanly re-join when link tracking times out. #314

Closed
terrillmoore opened this issue May 20, 2019 · 0 comments
Closed

Need a way to cleanly re-join when link tracking times out. #314

terrillmoore opened this issue May 20, 2019 · 0 comments
Assignees

Comments

@terrillmoore
Copy link
Member

Field testing with buggy gateways and intermittent networks indicates that link-tracking is fragile. If it gets to the point of wanting to rejoin, various things can happen, but generally things lock up.

The change that used OP_REJOIN to send an occasional join request simply doesn't work. In addition, although forcing a join at when we get to the end of our rope is not bad, because of issue #2, and because of the "dead gateway downlink" problem in TTN US, we really want to be sparing with triggering joins. Link tracking should not trigger a join until a much bigger count (unless, of course, the application decides it's a good idea). By much bigger, I mean thousands of uplinks without downlinks.

Perhaps once I replace engineUpdate() with a proper FSM, many of these things will be easier...

@terrillmoore terrillmoore self-assigned this May 20, 2019
terrillmoore added a commit that referenced this issue May 20, 2019
Fix #314: don't do (non-working) REJOIN; unjoin if out of sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant