Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API compatibility with node-mdns #5

Open
jamiees2 opened this issue Jul 30, 2014 · 6 comments
Open

API compatibility with node-mdns #5

jamiees2 opened this issue Jul 30, 2014 · 6 comments

Comments

@jamiees2
Copy link
Contributor

I was speculating if at this point, given the pull request, with a bit of additional work we could make this API compatible with node-mdns. What do you think?

@kmpm
Copy link
Collaborator

kmpm commented Jul 31, 2014

I can't seem to think of a reason to why not.
But I haven't studied the API of node-mdns. I can imagine that the API is somewhat colored by using Avahi as a base.
If we could nodeify it better without this compatibility requirement it needs to be discussed?

@jamiees2
Copy link
Contributor Author

I agree, but perhaps we could aim for something around 90% compatibility? I can see there being certain things that are impossible to do without native code, but i think it should be possible.

kmpm added a commit that referenced this issue Jul 31, 2014
Closes #4
Some work towards #5
@darkyen
Copy link
Contributor

darkyen commented Sep 29, 2014

@jamiees2 like ?

@jamiees2
Copy link
Contributor Author

Uhm, could you clarify like what? I don't quite understand 😜

@darkyen

@agnat
Copy link

agnat commented Nov 3, 2014

I can imagine that the API is somewhat colored by using Avahi as a base.

The node_mdns API isn't avahi based. It's an Apple mDNSResponder binding. In fact all of the API is implemented in JS as a thin object based wrapper around the native functions. It aims to hide the nativeness as good as possible. It's probably 1. easy and 2. fun to implement. If not, let me know... ;)

@agnat
Copy link

agnat commented Nov 3, 2014

Hey, I know this code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants