Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlanarityConstraint creates redundant pointsets #53

Open
bbrelje opened this issue Nov 12, 2020 · 0 comments
Open

PlanarityConstraint creates redundant pointsets #53

bbrelje opened this issue Nov 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@bbrelje
Copy link
Collaborator

bbrelje commented Nov 12, 2020

Description

The planarity constraint class is added using a pre-defined DVGeo pointset. However, at the time the constraint is created, an exact duplicate pointset is added to DVGeo creating unnecessary overhead.

Steps to reproduce issue

See TODO in PlanarityConstraint init method

Current behavior

Creates duplicate pointset and adds to DVGeo

Expected behavior

Should use original pointset in DVGeo
@ewu63 ewu63 added the bug Something isn't working label May 10, 2021
@sseraj sseraj added enhancement New feature or request and removed bug Something isn't working labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewu63 @bbrelje @sseraj