-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Recipe actions link to homepage for private recipes #4619
Comments
I love this idea |
If my idea sounds reasonable, I might have a look at it myself. Do you have a quick pointer on where to start with this? |
Mostly will be in here: mealie/frontend/composables/use-group-recipe-actions.ts Lines 49 to 56 in c0a4ae2
You'll probably want to add a merge field like ${temporary-url} or ${private-url-expires-1732852870} (where 1732852870 is a UNIX timestamp). Then you'll need to generate a temporary URL via the API: https://github.com/mealie-recipes/mealie/blob/mealie-next/frontend/lib/api/user/recipes/recipe-share.ts |
I like the idea of making the private url expiration configurable, but a unix-timestamp seems impractical. To actually use it, you would need to adjust the recipe action url often. IMO a field like ${private-url-expires-in-60} to expire in 60 seconds would be more useful, wouldn´t it? |
Yup that makes sense. Just spitballing! |
First Check
What is the issue you are experiencing?
When using a recipe action on a recipe that is not publicly shared, the resolution of that action fails (example: bring! api).
When checking the URL that mealie provides for placeholder ${url}, it is using the public link (for example https://demo.mealie.io/g/home/r/recipe-name ), which does only point to the recipe when logged in. Therefore, the API fails to perform the recipe action.
IMO the recipe action should automatically create a short lived share link for this case.
Steps to Reproduce
Please provide relevant logs
No relevant logs
Mealie Version
Docker v2.3.0
Deployment
Docker (Linux)
Additional Deployment Details
No response
The text was updated successfully, but these errors were encountered: