Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type errors when rendering children #755

Open
chrisvxd opened this issue Dec 29, 2024 · 2 comments
Open

Type errors when rendering children #755

chrisvxd opened this issue Dec 29, 2024 · 2 comments
Labels
in triage type: bug 🐛

Comments

@chrisvxd
Copy link
Member

A user has reported type errors when rendering children in render functions or overrides (tested in iframe override) in the latest build.

Steps to reproduce

Upgrade to latest and return children from a render function or iframe override. Suspect this may be due to a React 19 type mismatch.

What happens

TypeScript throws this error:

Type '{ children: ReactNode; }' is not assignable to type '{ children?: ReactNode; }'

What I expected to happen

No error to be thrown

Screenshots

image

image

image
@chrisvxd
Copy link
Member Author

chrisvxd commented Dec 30, 2024 •
edited
Loading

Struggling to reproduce. Requested repo or sandbox via Discord.

@chrisvxd
Copy link
Member Author

User resolved by clearing node modules / package-lock. Will likely close soon unless there are any further reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in triage type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisvxd