From aca70d43c3ddcbfae77496518ef818d87f87f41f Mon Sep 17 00:00:00 2001 From: Mukul Bansal Date: Wed, 4 Aug 2021 13:19:38 +0530 Subject: [PATCH] fix: lint issue and refactor prop name in dashboard component (#37) affects: @medly/create-app --- packages/app/README.md | 14 +++++++------- .../template/common/src/pages/Dashboard/types.ts | 4 +--- .../stateManagers/redux/src/store/sagas.ts | 6 ++---- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/packages/app/README.md b/packages/app/README.md index c4994a4..1266686 100644 --- a/packages/app/README.md +++ b/packages/app/README.md @@ -14,13 +14,13 @@ Then follow the prompts or you can run command `yarn create @medly/app ` | package manager | `npm`, `yarn`, `pnpm` | `yarn` | -| `-s, --state-manager ` | state manager | `redux`, `none` | `redux` | -| `-i, --interactive` | show interactive questionnaire | | | -| `-h, --help` | display help for command | | | +| Flags | Description | Choices | Default | +| ----------------------------------------- | ------------------------------ | ------------------------- | ------- | +| `-V, --version` | output the version number | | | +| `-p, --package-manager ` | package manager | `npm`, `yarn`, `pnpm` | `yarn` | +| `-s, --state-manager ` | state manager | `redux`, `context`,`none` | `redux` | +| `-i, --interactive` | show interactive questionnaire | | | +| `-h, --help` | display help for command | | | ## Features diff --git a/packages/app/template/common/src/pages/Dashboard/types.ts b/packages/app/template/common/src/pages/Dashboard/types.ts index ffb09e6..93cbbce 100644 --- a/packages/app/template/common/src/pages/Dashboard/types.ts +++ b/packages/app/template/common/src/pages/Dashboard/types.ts @@ -1,5 +1,3 @@ -export type StateProps = { +export type DashboardProps = { isLoading?: boolean; }; - -export type Props = StateProps; diff --git a/packages/app/template/stateManagers/redux/src/store/sagas.ts b/packages/app/template/stateManagers/redux/src/store/sagas.ts index eda5142..8e12682 100644 --- a/packages/app/template/stateManagers/redux/src/store/sagas.ts +++ b/packages/app/template/stateManagers/redux/src/store/sagas.ts @@ -1,8 +1,6 @@ -import { all } from 'redux-saga/effects'; import { userSaga } from '@store/user'; +import { all } from 'redux-saga/effects'; export function* rootSaga(): Generator { - yield all([ - userSaga() - ]); + yield all([userSaga()]); }