Change OrderService.getTotalsRelations from private to protected #8612
NicolasGorga
started this conversation in
Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey all,
A simple request here. I would like for OrderServcice.getTotalsRelations to be changed to protected, so we can override it when extending OrderService.
My use case: I implemented a Fee module, to charge a percentage of each order, for my multi vendor marketplace solution. I would like to override the original getTotalsRelations, to add to the default relations loaded for totals calculation, my custom 'fee' relation. I know i can pass this as part of the config, to whoever calls a function that calls this, but since i will always want this to be included in the relation, to not depend on the caller, the only solution is to be able to override getTotalsService.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions