Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] retry "no machting formats" #531

Open
FaySmash opened this issue Aug 10, 2024 · 1 comment
Open

[Improvement] retry "no machting formats" #531

FaySmash opened this issue Aug 10, 2024 · 1 comment

Comments

@FaySmash
Copy link
Contributor

After adding the ability to download live stream VODs the problem arose that many of the long streams aren't yet finished encoding by YouTube into the desired format and are skipped because of "no machting formats".
It would be great if those videos would be retried to get download with the same logic as if YT-DLP runs into an error while downloading (maybe up to 5-10x times).

@meeb
Copy link
Owner

meeb commented Aug 12, 2024

I've been pondering some sort of soft metadata retry method where if a download fails enough to be marked as permanently failed on the first permanent failure it'll clear then re-download its metadata. This should be about a day later which would likely account for issues like the one you've described. The only downside here, other than even more complex retry logic and some additional database counters, is that if you have a mass failure it'll schedule downloading a significant amount of metadata again which could cause issues for some people.

This has been on the cards for a while. I've also put this on the back-burner pending the hopeful replacement of the worker system given this feature would need to be redeveloped after replacing the worker system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants