Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next walk is not getting queued while changing directions #1027

Open
2 of 5 tasks
hugoj-goncalves opened this issue Jan 8, 2025 · 3 comments · May be fixed by #1028
Open
2 of 5 tasks

Next walk is not getting queued while changing directions #1027

hugoj-goncalves opened this issue Jan 8, 2025 · 3 comments · May be fixed by #1028
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@hugoj-goncalves
Copy link

Priority

Medium

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Expected:
It should queued next walk action if it's executed during an animation.

Current:
Next movement is just ignored.

Video:
https://github.com/user-attachments/assets/186f98c6-a78b-4727-a5b4-5b3306d3486b

Failed to record CipSoft client for comparison... 😢

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hugoj-goncalves hugoj-goncalves added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 8, 2025
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Jan 8, 2025
@hugoj-goncalves hugoj-goncalves changed the title Walking is not getting queued while changing directions Next walk is not getting queued while changing directions Jan 8, 2025
@kokekanon
Copy link
Collaborator

you should indicate which is protocol and version

@hugoj-goncalves
Copy link
Author

Should be able to reproduce in any protocol/version.
The code responsible for the next walk schedule was likely removed recently.

Kinda refactored in this commit, and completly removed later on.
5f61b5e#diff-6ce32c6cfe9efe1771fc9838d58d66ec9e1109bb10efa74efb6c7923ced7db70L53
5f61b5e#diff-affef3b48d01251c90ee530ca02913c0f3a65157db648286256cc787f5e4ba53L653

@Zbizu
Copy link
Contributor

Zbizu commented Jan 9, 2025 •
edited
Loading

issue confirmed on discord yesterday

to reproduce: try walking over this path by pressing left and down arrows fast
obraz

commenting two blocks in this:

otclient/src/client/game.cpp

Line 655 in c491e8f

// check we can walk and add new walk event if false

like that:
obraz

removes that limitation, but it also makes the walking drift as in qt client when you set the keyboard delay for too low + it also disconnects you for sending too many packets

@Zbizu Zbizu mentioned this issue Jan 9, 2025
Open
5 tasks
@nekiro nekiro linked a pull request Jan 9, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve: refactor walking for better responsivenes nekiro/otclient
3 participants
@Zbizu @hugoj-goncalves @kokekanon