Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messing around with login window may crash the client. #1034

Open
2 of 5 tasks
hugoj-goncalves opened this issue Jan 12, 2025 · 0 comments
Open
2 of 5 tasks

Messing around with login window may crash the client. #1034

hugoj-goncalves opened this issue Jan 12, 2025 · 0 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@hugoj-goncalves
Copy link

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Starting login process and cancelling may crash the client or simply freeze it forever. When it does freezes it triggers no exception.
Hard to reproduce at localhost due to low latency.

Looks like a use after free here due to the LoginHttp ref in the detach_task of httpLogin.
image
image

Video:
https://github.com/user-attachments/assets/ab5c2ec3-a3d9-4796-bb7a-ce283a113dfe

PS: I don't know if the client freeze is due to the use after free, but it does happen relatively "often" even on localhost without any exceptions whatsoever.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hugoj-goncalves hugoj-goncalves added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 12, 2025
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugoj-goncalves