Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using updater, sound starts playing even when disabled #1043

Open
2 of 5 tasks
lucasoares opened this issue Jan 14, 2025 · 1 comment
Open
2 of 5 tasks

When using updater, sound starts playing even when disabled #1043

lucasoares opened this issue Jan 14, 2025 · 1 comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@lucasoares
Copy link
Contributor

lucasoares commented Jan 14, 2025

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

I think there may be few issues with how the updater handles the modules loading. Or maybe how the sound system is started.

I have not dig enough yet of what is going on. For some reason when I enable the updater, the sound starts playing even with the sound disabled (the icon shows the sound disabled, but the sound is played). This shows that something is not right with how updater handle everything. With the updater disabled, the loadModules is run directly on init.lua, but when enabling the updater, it will run only after the updater finishes its process.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lucasoares lucasoares added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 14, 2025
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Jan 14, 2025
@lucasoares
Copy link
Contributor Author

As discussed on #1032 (comment) I'm changing this issue name to focus on the sound system.

@lucasoares lucasoares changed the title When using updater, configurations doesn't seems to be loaded correctly in some cases When using updater, sound starts playing even when disabled Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

1 participant