Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] LCs not recognized when using multiple Triggerscopes #312

Open
edyoshikun opened this issue Feb 6, 2023 · 5 comments · May be fixed by #318
Open

[BUG] LCs not recognized when using multiple Triggerscopes #312

edyoshikun opened this issue Feb 6, 2023 · 5 comments · May be fixed by #318
Assignees
@edyoshikun
Labels
bug Something isn't working

Comments

@edyoshikun
Copy link
Contributor

For most setups, the use of one triggerscope so the current method for detecting and setting the voltages through the DAC by parsing TS_DAC from device properties works well. However, in the case of the Mantis where we have the triggerscope device named as TS1_DAC instead of TS_DAC our current string parsing fails.

Check the following:
main_widget.py and Calibration.py will need to have some edits to recognize the triggerscope name.
@edyoshikun edyoshikun added the bug Something isn't working label Feb 6, 2023
@ziw-liu
Copy link
Contributor

ziw-liu commented Feb 10, 2023

Can the triggerscope used to control LCs be renamed as TS_DAC?

@edyoshikun
Copy link
Contributor Author

At least for the mantis application with two triggerscopes we named one TS1 and the second TS2. I guess we can change this on our side.
What do you think? @ieivanov

@ziw-liu
Copy link
Contributor

ziw-liu commented Feb 10, 2023

At least for the mantis application with two triggerscopes we named one TS1 and the second TS2.

I think from recOrder's side, it's not obvious that one of the arbitrarily named TS* should be responsible for LCs. We can edit the expected TS name to a more descriptive one, but considering backwards compatibility it might be just easier to change TS1 to TS on the Mantis.

@ieivanov
Copy link
Contributor

We shouldn't be hardcoding the device name in recOrder. This has worked for now, but will be hard to control over many microscopes. If we change the device name, then any code written for that device will also need to change.

Instead, we use use the MM API to enumerate IO and DAC devices and then recOrder can ask the user to pick between TS1:DAC1, TS1_DAC2, TS2:DAC1, etc. for controlling the LCs

@edyoshikun edyoshikun linked a pull request Feb 14, 2023 that will close this issue
Draft
@mattersoflight mattersoflight added this to the 0.3.0 milestone Feb 17, 2023
@talonchandler
Copy link
Collaborator

I'm removing this from 0.3.0 since it's not strictly necessary. We can release it whenever it's fixed.

@talonchandler talonchandler removed this from the 0.3.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edyoshikun edyoshikun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added option to parse through TS or DAC mehta-lab/recOrder
5 participants
@mattersoflight @talonchandler @edyoshikun @ieivanov @ziw-liu