Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda_illu, NA_obj, and NA_illu names can be improved #91

Closed
talonchandler opened this issue Nov 17, 2022 · 1 comment · Fixed by #121
Closed

lambda_illu, NA_obj, and NA_illu names can be improved #91

talonchandler opened this issue Nov 17, 2022 · 1 comment · Fixed by #121
Assignees

Comments

@talonchandler
Copy link
Collaborator

The waveorder_microscopy constructor contains the following lines:

self.lambda_illu = lambda_illu/n_media
self.NA_obj = NA_obj/n_media
self.NA_illu = NA_illu/n_media
which creates confusion when reading the methods and refactoring.

I am planning to make the following changes:

  1. Rename self.lambda_illu to self.lambda_media because lambda_illu/n_media is the wavelength inside the immersion media. It's particularly important to keep track of what media we're in because we have plans to to reconstructions in layered samples (immersion media, water, etc).

  2. Do not change the names ofself.NA_obj and self.NA_illu, but make them true to their names and don't normalize by n_media.

@talonchandler talonchandler self-assigned this Nov 17, 2022
@talonchandler
Copy link
Collaborator Author

The models in alg-dev now use much more descriptive names
(numerical_aperture_illumination, numerical_aperture_detection, wavelength_illumination, index_of_refraction_media), so this is solved.

@talonchandler talonchandler linked a pull request Jul 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant