From 919d7cd60a3f5f5268697349f823aea439c742d5 Mon Sep 17 00:00:00 2001 From: Bruno Casali Date: Tue, 21 May 2024 15:56:24 -0300 Subject: [PATCH 1/3] Update nodejs runtime Fixes https://github.com/meilisearch/firestore-meilisearch/issues/178 --- extension.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension.yaml b/extension.yaml index b45e379..320f4fd 100644 --- a/extension.yaml +++ b/extension.yaml @@ -62,7 +62,7 @@ resources: # LOCATION is a user-configured parameter value specified by the user # during installation. location: ${LOCATION} - runtime: nodejs14 + runtime: nodejs20 eventTrigger: eventType: providers/cloud.firestore/eventTypes/document.write resource: projects/${PROJECT_ID}/databases/(default)/documents/${COLLECTION_PATH}/{documentID} From 8fe5880999b7f1000ac636a311bfeb499263c0e0 Mon Sep 17 00:00:00 2001 From: Bruno Casali Date: Tue, 21 May 2024 15:59:33 -0300 Subject: [PATCH 2/3] Update node version all across the app --- .github/workflows/test.yml | 12 ++++++------ bors.toml | 7 +------ 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cfca8db..60aa3cf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,11 +18,11 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: ['14', '16', '18'] + node: ['20'] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - name: Install dependencies @@ -33,11 +33,11 @@ jobs: runs-on: ubuntu-latest name: style-check steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 20 - name: Install dependencies run: yarn install:functions - name: Run style check diff --git a/bors.toml b/bors.toml index db1a676..307460e 100644 --- a/bors.toml +++ b/bors.toml @@ -1,8 +1,3 @@ -status = [ - 'style-check', - 'integration-tests (14)', - 'integration-tests (16)', - 'integration-tests (18)' -] +status = ['style-check', 'integration-tests (20)'] # 1 hour timeout timeout-sec = 3600 From d7678cecd69612ced3d32b983601942c2a97a2a7 Mon Sep 17 00:00:00 2001 From: Bruno Casali Date: Tue, 21 May 2024 16:01:43 -0300 Subject: [PATCH 3/3] Update CI files with new node version --- .github/workflows/beta-tests.yml | 6 +++--- .github/workflows/pre-release-tests.yml | 6 +++--- .github/workflows/publish.yml | 6 +++--- CONTRIBUTING.md | 2 +- functions/package.json | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/beta-tests.yml b/.github/workflows/beta-tests.yml index 809d3df..b630e54 100644 --- a/.github/workflows/beta-tests.yml +++ b/.github/workflows/beta-tests.yml @@ -13,12 +13,12 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: ['14', '16', '18'] + node: ['20'] name: integration-tests (Node.js ${{ matrix.node }}) steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - name: Install dependencies diff --git a/.github/workflows/pre-release-tests.yml b/.github/workflows/pre-release-tests.yml index 95cc594..ccc179f 100644 --- a/.github/workflows/pre-release-tests.yml +++ b/.github/workflows/pre-release-tests.yml @@ -13,12 +13,12 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: ['14', '16', '18'] + node: ['20'] name: integration-tests (Node.js ${{ matrix.node }}) steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - name: Install dependencies diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 765d52a..629a7e5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,10 +7,10 @@ jobs: publish-npm: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 14 + node-version: 20 registry-url: https://registry.npmjs.org/ - name: Check release validity run: sh .github/scripts/check-release.sh diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 27a0f99..a3c3057 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,7 +36,7 @@ First of all, thank you for contributing to Meilisearch! The goal of this docume To run this project, you will need: -- Node >= 14 && node <= 18 +- Node >= 20 - Npm >= v7 - A google account - Version `v10.9.2` of `firebase-tools` the Firebase CLI (latest does not provide the emulator): diff --git a/functions/package.json b/functions/package.json index 74406f0..49fe74e 100644 --- a/functions/package.json +++ b/functions/package.json @@ -17,7 +17,7 @@ "test:coverage": "jest --coverage" }, "engines": { - "node": ">=14.0.0" + "node": ">=20.0.0" }, "main": "lib/index.js", "dependencies": {