feat: handle correctly when replica count is set to 0 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meilisearch sync-manifest |
|
Hey @Tchoupinax can you fix the conflicts? |
|
@meilisearch sync-manifest |
brunoocasali
approved these changes
Sep 16, 2024
brunoocasali
requested changes
Sep 16, 2024
Sorry just got your message. It's done now! |
|
bors try |
tryBuild failed: |
|
@meilisearch sync-manifest |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Oct 2, 2024
238: feat: handle correctly when replica count is set to 0 r=brunoocasali a=Tchoupinax Hello, This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it. My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier Thank for your work! Co-authored-by: Tchoupinax <[email protected]> Co-authored-by: brunoocasali <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Build failed: |
|
@meilisearch sync-manifest |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Oct 2, 2024
238: feat: handle correctly when replica count is set to 0 r=brunoocasali a=Tchoupinax Hello, This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it. My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier Thank for your work! Co-authored-by: Tchoupinax <[email protected]> Co-authored-by: brunoocasali <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Build failed:
|
brunoocasali
reviewed
Oct 2, 2024
|
@meilisearch sync-manifest |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Oct 2, 2024
238: feat: handle correctly when replica count is set to 0 r=brunoocasali a=Tchoupinax Hello, This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it. My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier Thank for your work! Co-authored-by: Tchoupinax <[email protected]> Co-authored-by: brunoocasali <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Build failed: |
brunoocasali
requested changes
Oct 2, 2024
charts/meilisearch/Chart.yaml
Outdated
There was a problem hiding this comment.
@Tchoupinax I can't look into why the CI is not working right now. Can you take a look at it, please?
There was a problem hiding this comment.
|
@meilisearch sync-manifest |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Oct 16, 2024
238: feat: handle correctly when replica count is set to 0 r=brunoocasali a=Tchoupinax Hello, This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it. My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier Thank for your work! Co-authored-by: Tchoupinax <[email protected]> Co-authored-by: brunoocasali <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
brunoocasali
approved these changes
Oct 16, 2024
|
Build failed: |
|
Hey @Tchoupinax, I was not able to understand what's missing here, I agree with your PR, but I don't have time to investigate the issue happening in the CI. I'm going to close this PR, feel free to reopen if you want to fix it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it.
My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier
Thank for your work!