You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
Rewrite much of the code base to make it easier to maintain and more stable.
This suggestion is only aimed at the code a user might interact with, I made a separate issue for refactoring the test suite: #300.
Basic example
lib/meilisearch.rb is far too big to reason about
Similarly named instance and class methods where one often just calls the other
Return values are sort of random and inconsistent
Methods often have side-effects
Methods often have hacks waiting to break at any moment
Inconsistent public API when it comes to ! methods and method names in general
Flags in method parameters (product.index!(true) does not express what true means)
Poor error reporting (indexing can fail with no warning or return value provided to the user)
There needs to be restructuring to integrate methods or classes to filter by an ActiveRecord (or other ORM) query, such as suggested in CanCan aware ms_search implementation #255
Description
Rewrite much of the code base to make it easier to maintain and more stable.
This suggestion is only aimed at the code a user might interact with, I made a separate issue for refactoring the test suite: #300.
Basic example
lib/meilisearch.rb
is far too big to reason about!
methods and method names in generalproduct.index!(true)
does not express whattrue
means)meilisearch
method)The text was updated successfully, but these errors were encountered: