Add 'Burger Discounts' chapter #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feihong
force-pushed
the
burger-discounts
branch
from
b94cd54
to
d2967b1
Compare
jchavarri
requested changes
Apr 8, 2024
jchavarri
approved these changes
Apr 9, 2024
Comment on lines
+7
to
+8
| > Given an order comprising multiple items, find the price of the second most | ||
| > expensive burger. Subtract this number from the pre-tax total of the order. |
There was a problem hiding this comment.
Wouldn't it be something like this? To make it more generic:
Suggested change
| > Given an order comprising multiple items, find the price of the second most | |
| > expensive burger. Subtract this number from the pre-tax total of the order. | |
| > Given an order comprising multiple items, for every two burgers ordered find the | |
| > price of the less expensive one. Subtract this number from the pre-tax total of the | |
| > order. |
There was a problem hiding this comment.
This makes more sense, but I would like to implement it in the next chapter
docs/burger-discounts/index.md
Outdated
Comment on lines
355
to
361
| As an extra precaution, you might want to catch the exception inside the switch | ||
| expression: | ||
|
|
||
| <<< Discount.re#catch-exception{5} | ||
|
|
||
| With the current logic, it's not impossible to reach the exception branch, but | ||
| who knows how the code might evolve in the future. |
There was a problem hiding this comment.
Maybe this could be shared as an alternative approach? Rather than "as an extra precaution", something like "as an alternative approach", and then share the code with exn handling and without the .length check.
There was a problem hiding this comment.
Agree, catching the exception is described as alternate approach in 4184366
docs/burger-discounts/index.md
Outdated
Comment on lines
365
to
367
| It looks like `burger[0]` is using an array access operator, but it's actually | ||
| just a function call. That is, `burger[0]` is completely equivalent to | ||
| `Array.get(burger, 0)`. |
There was a problem hiding this comment.
Suggested change
| It looks like `burger[0]` is using an array access operator, but it's actually | |
| just a function call. That is, `burger[0]` is completely equivalent to | |
| `Array.get(burger, 0)`. | |
| In OCaml, array access operators like `burger[0]` are actually just a | |
| function call. That is, `burger[0]` is completely equivalent to | |
| `Array.get(burger, 0)`. |
There was a problem hiding this comment.
Reworded in 20a777b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions. In those cases, you can give the compiler more information:
Stdlibmodule is opened by defaultfor some fields
value is
()), so you can useStdlib.ignoreto explicitly discard returnvalues
None->undefinedSome(value)->valuearray[index]is actually just a call toArray.get(array, index)Arraymodule to override the behavior ofArray.get