Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gentype #916

Open
jchavarri opened this issue Nov 21, 2023 · 2 comments
Open

Support gentype #916

jchavarri opened this issue Nov 21, 2023 · 2 comments

Comments

@jchavarri
Copy link
Member

Mostly dumping what @anmonteiro and @andreypopp mentioned on Discord:

Approach 1 (conservative)

  • port gentype to a melange-compatible typedtree
  • implement dune rules to call gentype after compilation

Approach 2 (experimental)

Implement gentype as a deriving ppx that operates over mli/rei files. This approach wouldn't require typed tree nor custom dune rules, so in that sense it's simpler. But because the original gentype does rely on typed tree, it probably requires quite some more changes than the conservative approach.

@XantreDev
Copy link

XantreDev commented Feb 24, 2024

port gentype to a melange-compatible typedtree

Are typedtrees significantly different?

@jchavarri
Copy link
Member Author

I am not 100% sure but I suspect they must be quite similar. The largest differences will probably be caused by Melange supporting a much modern version of the OCaml compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants