From 11da1b4821bfabf8f3e4cee5e0793f357bf4da84 Mon Sep 17 00:00:00 2001 From: Vini Salazar <17276653+vinisalazar@users.noreply.github.com> Date: Mon, 14 Oct 2024 19:12:47 +1100 Subject: [PATCH 1/3] Add more instructions to PR exercise --- docs/tutorials/git/git.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/tutorials/git/git.md b/docs/tutorials/git/git.md index 304c21fd..43a315af 100644 --- a/docs/tutorials/git/git.md +++ b/docs/tutorials/git/git.md @@ -951,9 +951,10 @@ If you have your project available on GitHub, it is likely that you will have to Because of that, let's practice **reviewing** a pull request, that is, the scenario where someone would submit a pull request to our repository. ???+ question "Reviewing a pull request" - 1. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork. - 2. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository. - 3. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button:** + 1. Create a new branch called `add-name` using the following command: `git checkout -b add-name`. + 2. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork, using the following command: `git push --set-upstream origin add-name` + 3. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository. + 4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch. ![](./media/PR_base_repository.png) From 27c6993ec390e940e40ea67326d720a58450b8b6 Mon Sep 17 00:00:00 2001 From: Vini Salazar <17276653+vinisalazar@users.noreply.github.com> Date: Mon, 14 Oct 2024 19:24:16 +1100 Subject: [PATCH 2/3] Add uncheck box instruction --- docs/tutorials/git/git.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/git/git.md b/docs/tutorials/git/git.md index 43a315af..313c96bc 100644 --- a/docs/tutorials/git/git.md +++ b/docs/tutorials/git/git.md @@ -954,7 +954,7 @@ Because of that, let's practice **reviewing** a pull request, that is, the scena 1. Create a new branch called `add-name` using the following command: `git checkout -b add-name`. 2. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork, using the following command: `git push --set-upstream origin add-name` 3. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository. - 4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch. + 4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch. **Keep the "Allow Edits by Maintainers" box UNCHECKED.** ![](./media/PR_base_repository.png) From 7c497c0ee58b0912285c01ea0092717d89adb61a Mon Sep 17 00:00:00 2001 From: Vini Salazar <17276653+vinisalazar@users.noreply.github.com> Date: Mon, 14 Oct 2024 19:26:50 +1100 Subject: [PATCH 3/3] Remove instruciton added in previous commit --- docs/tutorials/git/git.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/git/git.md b/docs/tutorials/git/git.md index 313c96bc..43a315af 100644 --- a/docs/tutorials/git/git.md +++ b/docs/tutorials/git/git.md @@ -954,7 +954,7 @@ Because of that, let's practice **reviewing** a pull request, that is, the scena 1. Create a new branch called `add-name` using the following command: `git checkout -b add-name`. 2. Create a file named `CONTRIBUTORS.txt` and add a line with your name to it. Add and commit the changes, and push to your fork, using the following command: `git push --set-upstream origin add-name` 3. Find someone that has forked the same repository as you have (either Python or R). Ask a helper if you can't find someone that has cloned the same repository. - 4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch. **Keep the "Allow Edits by Maintainers" box UNCHECKED.** + 4. Using the GitHub interface, make a pull request to each other's repository submitting the changes. **Change the destination of your PR by using the dropdown menus above the "Create pull request" button.** Make sure you make the pull request to your partner's fork, and to the `add-name` branch. ![](./media/PR_base_repository.png)