You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Again, your work on this is BRILLIANT!!!! I do have one suggestion. There may be cases where the signaling server needs to be set at runtime vs a static config file. While the MemoryConfigurationSource seems to be an option on Xamarin, it doesn't seem to work with the Blazor implementation. Perhaps creating a service that provides a runtime URL and injecting it into the SignalingStub constructor. Maybe something like this:
`namespace WebRTCme.Connection.Signaling.Proxy.Interfaces
{
public interface ISignalingUrlProvider
{
string GetSignalingServerUrl();
}
Again, your work on this is BRILLIANT!!!! I do have one suggestion. There may be cases where the signaling server needs to be set at runtime vs a static config file. While the MemoryConfigurationSource seems to be an option on Xamarin, it doesn't seem to work with the Blazor implementation. Perhaps creating a service that provides a runtime URL and injecting it into the SignalingStub constructor. Maybe something like this:
`namespace WebRTCme.Connection.Signaling.Proxy.Interfaces
{
public interface ISignalingUrlProvider
{
string GetSignalingServerUrl();
}
}`
` Interfaces.ISignalingUrlProvider signalingUrlProvider;
public SignalingStub(IConfiguration configuration, Interfaces.ISignalingUrlProvider sigProvider)
{
_signallingServerBaseUrl = configuration["SignallingServer:BaseUrl"];
// Rest of your constructor`
Then adding an implementation of ISignalingUrlProvider and injecting it at startup.
builder.Services.AddSingleton<WebRTCme.Connection.Signaling.Proxy.Interfaces.ISignalingUrlProvider, Services.SignalingServerUrlProvider>();
The text was updated successfully, but these errors were encountered: