Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: take --env-file parameter #48

Closed
jimsheldon opened this issue Feb 12, 2021 · 2 comments · Fixed by #95
Closed

Feature request: take --env-file parameter #48

jimsheldon opened this issue Feb 12, 2021 · 2 comments · Fixed by #95
Labels
enhancement New feature or request

Comments

@jimsheldon
Copy link
Contributor

Feature

This would be essentially the same as how drone-server takes --env-file=<path> to set environment variables.

More discussion in #41
@jimsheldon jimsheldon added the enhancement New feature or request label Feb 12, 2021
@jimsheldon jimsheldon changed the title Feature request: take --env-file parameter Feature request: take --env-file parameter Feb 12, 2021
@jimsheldon jimsheldon mentioned this issue Feb 12, 2021
Closed
@abdennour
Copy link

any plan to release this helm chart?

@jimsheldon
Copy link
Contributor Author

Hello @abdennour

This change would be to just the plugin, if we end up working on a helm chart that would have to support this feature (if we implement it). It looks like you are already following #49 where we are considering helm chart support.

@foymikek foymikek mentioned this issue Apr 4, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add documentation and env file path meltwater/drone-convert-pathschanged
2 participants
@jimsheldon @abdennour