Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines with include triggers all ran when an empty commit was made #45 #99

Open
ssaitta opened this issue Oct 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ssaitta
Copy link

ssaitta commented Oct 5, 2023

Observed Behaviour

I recently made an empty commit and our pipelines triggered by include clauses all kicked off. This was problematic for us since we have production infra pipelines which we did not want kicked off at that time, and could have caused outages for us.

Steps to Reproduce

  1. Include a path include trigger on your pipeline.
  2. Push a commit with no files.

Expected Behaviour

I would expect pipelines triggered by include clauses to only go off if that path name is matched by a changed file, so no include pipeline should run.

I saw this bug report from 2 years ago and this issue is basically the opposite case. The author of this bug report says "The pipeline should run, since none of the files didn't match (can't exclude nothing)." and we have the case where no files were included so the pipeline should not run, since none of the files were included.

@ssaitta ssaitta added the bug Something isn't working label Oct 5, 2023
@ssaitta ssaitta changed the title Pipelines with include triggers all tan when an empty commit was made #45 Pipelines with include triggers all ran when an empty commit was made #45 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant