Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating multiple step modules #5

Open
hyperthunk opened this issue Jul 1, 2011 · 0 comments
Open

Consider deprecating multiple step modules #5

hyperthunk opened this issue Jul 1, 2011 · 0 comments

Comments

@hyperthunk
Copy link
Contributor

The use of multiple step modules for a single feature (file) seems a little haphazard. It's intent appears to be sharing of code (i.e., step function definitions) between modules, but I think there are other, cleaner ways to do this.

The use of helper modules, for example, would alleviate the need for this, and is supported on the cli (see https://github.com/hyperthunk/cucumberl/blob/master/src/cucumberl_cli.erl#L45) and could easily be moved into the main cucumber module.

Also, not processing multiple step modules would simplify error handling and negate the requirement to always implement a stub function clause in your modules, i.e.,

%% no more of these!!!
step(_, _) -> undefined.

Please let me know if you would consider this change, as I'd be happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant