Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bundlex] attempting to compile projects fail on windows #916

Open
ValorZard opened this issue Nov 21, 2024 · 3 comments
Open

[Bundlex] attempting to compile projects fail on windows #916

ValorZard opened this issue Nov 21, 2024 · 3 comments

Comments

@ValorZard
Copy link

ValorZard commented Nov 21, 2024

** (Mix) Bundlex: Unable to find vcvarsall.bat script within Visual Studio root directory. Is your Visual Studio installation valid? (and file is in VC directory?)
i keep getting this error and its really annoying,
it seems to be an issue with how https://github.com/membraneframework/bundlex/blob/240f889a26c3e974d3faea36a27849bdd6c27ff2/lib/bundlex/toolchain/visual_studio.ex is hardcoded

Attempting to compile https://github.com/FatigueDev/exray

@mat-hek
Copy link
Member

mat-hek commented Nov 22, 2024

Hi there, the support for Windows in Bundlex is quite poor, and we can't prioritize it anytime soon. We help anyone from the community who contributes though. There were some fixes recently thanks to @harrisi, but it may not be enough to compile Exray. Here's the relevant discussion.

@harrisi
Copy link
Contributor

harrisi commented Nov 22, 2024

There are a few things with the project setup of exray which don't allow for Windows compilation without some changes, such as relying on a Linux tarball of raylib, so you may want to open an issue over there as well.

For what it's worth, the path for vcvarsall.bat isn't hardcoded anymore, specifically to fix this issue. It uses vswhere.exe to find it, so as long as your dev environment is set up correctly, it should find it. It runs "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -property installationPath -latest, which if that doesn't return the correct path, I'm guessing msvc isn't set up correctly.

You can also always try using the custom compiler toolchain and use zig cc. I had some luck with that before.

@mat-hek
Copy link
Member

mat-hek commented Nov 27, 2024

Okay, it seems we forgot to release @harrisi's latest PR... It's now released as https://github.com/membraneframework/bundlex/releases/tag/v1.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants