Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icon_mappings.json #295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update icon_mappings.json #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
551ec6b
Update icon_mappings.json
rannil-kumar May 2, 2024
f634e61
Add files via upload
rannil-kumar May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/icon-replacer-tool/icon_mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,5 +276,6 @@
"person_grey_child.png": "avatar__child--125-enabled.svg",
"icon_days_left.png": "days-left—20-enabled.svg",
"icon_reaching_time_limit.png": "days-reaching-limit--20-enabled.svg",
"icon_reaching_time_limit_hover.png": "days-reaching-limit--20-enabled.svg"
"icon_reaching_time_limit_hover.png": "days-reaching-limit--20-enabled.svg",
"days-left—20-enabled.svg": "days-left-20-enabled.svg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key/filename on the left should be the old icon filename that is being replaced.

If you are not replacing an existing icons, then you don't need to add an entry into this mapping.

Also to note, this icon is already in the mappings on line 277 but the filename is incorrect. It's missing a double dash between "left" and "20".

}
14 changes: 14 additions & 0 deletions packages/icon-replacer-tool/source_files/days-left-20-enabled.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.