Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github apply notification not goes to the current commit #96

Open
vmatyus opened this issue Jul 26, 2021 · 1 comment
Open

Github apply notification not goes to the current commit #96

vmatyus opened this issue Jul 26, 2021 · 1 comment

Comments

@vmatyus
Copy link

vmatyus commented Jul 26, 2021

WHAT

My project uses tfnotify with Github and Travis as CI.
A CI execution for a specific commit also produces a plan and an apply results.
The plan result goes to the actual commit, that the CI was executed on, while the apply result goes to the previous commit. It would be good if an execution result would go to the same commit and this commit would be the actual commit.

WHY

To review back the CI execution results, it is easier to compare the plan and apply results, if it goes to the current commit.

I tried to create an image that depicts the current operation:

Screenshot 2021-07-26 at 16 06 40

@fnaoto
Copy link

fnaoto commented Sep 28, 2021

I hope this could help you ;)

tfnotify get commit number from environment variables of travis ci.

If pull request is opened, using TRAVIS_PULL_REQUEST_SHA .
And also there is no pull request, using TRAVIS_COMMIT

It means, comment on commit depends on Pull Request Status.

Code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants