Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mergeable failing to request reviews and post comments on pull requests #724

Open
DanielTsiang opened this issue Jul 25, 2023 · 2 comments

Comments

@DanielTsiang
Copy link

DanielTsiang commented Jul 25, 2023

Recently over the past few months I've noticed that Mergeable fails to request reviews and post comments on pull requests when it should do.

It was working last year, I haven't changed any of the mergeable.yml config but it's stopped working sometime this year for some unknown reason.

@shine2lay
Copy link
Member

@DanielTsiang does it happen sporadically or all the time?

@DanielTsiang DanielTsiang changed the title Mergeable failing to request PR reviews and post messages Mergeable failing to post comments on pull requests Jul 26, 2023
@DanielTsiang
Copy link
Author

DanielTsiang commented Jul 26, 2023

@shine2lay it hasn't been working all the time for a while now.

Here is a snippet of the relevant part of the mergeable.yml config to help with debugging:

version: 2
mergeable:
  - when: pull_request.opened, pull_request.edited, pull_request.reopened, pull_request.ready_for_review
    filter:
      - do: payload
        pull_request:
          draft:
            boolean:
              match: false
    validate:
      - do: changeset
        must_include:
          regex: '^(dir-1)\/(?<service>service-1|service-2|service-3)\/(\k<service>)(\.env)$'
        files:
          added: true
          modified: true
          deleted: true
    pass:
      - do: comment
        payload:
          body: >
            The relevant team will need to control merging this PR.
            
            @relevant-team: please review this PR.
  - when: pull_request.opened, pull_request.edited, pull_request.reopened, pull_request.labeled, pull_request.unlabeled, pull_request.synchronize
    validate:
      - do: changeset
        must_include:
          regex: '.*/.env'
          message: 'Contains env changes...'
        files:
          added: true
          modified: true
          deleted: true
    pass:
      - do: request_review
        reviewers: ['user1']

@DanielTsiang DanielTsiang changed the title Mergeable failing to post comments on pull requests Mergeable failing to request reviews and post comments on pull requests Jul 26, 2023
@DanielTsiang DanielTsiang changed the title Mergeable failing to request reviews and post comments on pull requests [Bug] Mergeable failing to request reviews and post comments on pull requests Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants