Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buttons that share data externally to allow safe self-hosting #1511

Open
bluprince13 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #1528
Open

Disable buttons that share data externally to allow safe self-hosting #1511

bluprince13 opened this issue Aug 23, 2024 · 1 comment · May be fixed by #1528
Labels
enhancement New feature or request

Comments

@bluprince13
Copy link

Is your feature request related to a problem? Please describe.
One of the reasons users might self-host is because they want to prevent data being leaked out of their company/org. However, there are buttons on the UI that allow users to share their diagram with other website. For example, with https://mermaid.ink/ or https://kroki.io/ or https://www.mermaidchart.com. Some of the problem locations that I could see are highlighted in the image below. I don't know if there are others I haven't noticed.

CleanShot 2024-08-23 at 18 21 39

Describe the solution you'd like
It would be nice if these could be disabled using environment variables. For example, if rendererUrl and krokiRendererUrl are empty, then the respective buttons could be hidden.

For the mermaid chart links,

  1. the link to https://mermaidchart.com/ on the icon at the top right
  2. notification at the top linking to mermaidchart

Even though clicking on the link doesn't directly result in a data leak, it could still mislead users into thinking that it's okay to share the data on https://www.mermaidchart.com/.

Describe alternatives you've considered
Could modify the code to get the desired effect, however then it could get annoying to resolve merge conflicts when pulling the latest version of this repo. An easy way to toggle these off via env variables might be something the community would benefit from.

Additional context
I'm not very optimistic about this feature request being accepted, but thought it couldn't hurt to ask. Feels like these would be simple changes, so happy to raise a PR too.

@bluprince13 bluprince13 added the enhancement New feature or request label Aug 23, 2024
@sidharthv96
Copy link
Member

Totally makes sense to disable those in the self hosted version, please raise PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants