Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from setup.py to pyproject.toml using PDM #293

Open
rugeli opened this issue Oct 15, 2024 · 1 comment · May be fixed by #294
Open

Migrate from setup.py to pyproject.toml using PDM #293

rugeli opened this issue Oct 15, 2024 · 1 comment · May be fixed by #294
Assignees
Labels
enhancement New feature or request

Comments

@rugeli
Copy link
Collaborator

rugeli commented Oct 15, 2024

Use Case

As we integrate more closely with AWS services and frontend work, using modern packaging standards will benefit our development workflow and simplify dependency management

Solution

Please describe your ideal solution

  • install Poetry we decided to use pyenv +pdm after discussion
  • create a pyproject.toml file
  • update github action workflows to use Poetry commands
  • update Dockerfile (if it's merged into main)
  • update README
@rugeli rugeli added the enhancement New feature or request label Oct 15, 2024
@rugeli rugeli self-assigned this Oct 15, 2024
@mogres
Copy link
Collaborator

mogres commented Oct 15, 2024

Thanks for adding this issue! It would be an excellent update for dependency management for this project. Adding some thoughts here for discussion:

Another alternative to poetry is PDM, which we have used for package management in other projects. Either would work for our use case.

One more thing to consider with this change would be to move away from third party conda virtual environments and stick to native solutions like venv. Note that this will require using pyenv to manage python versions.

@mogres mogres linked a pull request Oct 17, 2024 that will close this issue
@rugeli rugeli changed the title Migrate from setup.py to pyproject.toml using Poetry Migrate from setup.py to pyproject.toml using PDM Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants