Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad output after 80k tokens: rope scaling_factor 8 is used for 1B and 3B 3.2 models #241

Open
yieldthought opened this issue Dec 10, 2024 · 2 comments

Comments

@yieldthought
Copy link

yieldthought commented Dec 10, 2024

The rope scaling factor is hard-coded to 8 but the correct value for the 1B and 3B 3.2-series models is 32, as updated on the huggingface repo in this post-release fix.

The current value of 8 is correct for 3.1 models, for 11B and 90B 3.2 and for 70B 3.3, so this should be taken from the model config setup and not hard-coded.

This is not apparent at short sequence lengths but causes a dramatic degradation around 80k tokens.

@yieldthought yieldthought changed the title rope scaling_factor 8 is still used for 3.2+ models Bad output after 80k tokens: rope scaling_factor 8 is still used for 3.2+ models Dec 10, 2024
@yieldthought
Copy link
Author

yieldthought commented Dec 10, 2024

I notice #166 was closed without a resolution; @varunfb the current implementation is just wrong for the 1B and 3B models.

@yieldthought yieldthought changed the title Bad output after 80k tokens: rope scaling_factor 8 is still used for 3.2+ models Bad output after 80k tokens: rope scaling_factor 8 is still used for 1B and 3B 3.2 models Dec 10, 2024
@yieldthought yieldthought changed the title Bad output after 80k tokens: rope scaling_factor 8 is still used for 1B and 3B 3.2 models Bad output after 80k tokens: rope scaling_factor 8 is used for 1B and 3B 3.2 models Dec 10, 2024
@mtairum
Copy link

mtairum commented Dec 13, 2024

Merged with PR tenstorrent/tt-metal#15909

Can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants