Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getting_started.ipynb link on llama.com is a 404 #633

Open
simonw opened this issue Dec 15, 2024 · 1 comment
Open

getting_started.ipynb link on llama.com is a 404 #633

simonw opened this issue Dec 15, 2024 · 1 comment

Comments

@simonw
Copy link

simonw commented Dec 15, 2024 •
edited
Loading

System Info

iPhone Mobile Safari

🐛 Describe the bug

This "Learn more" link on https://www.llama.com/ links to https://github.com/meta-llama/llama-stack/blob/main/docs/getting_started.ipynb which is a 404.

IMG_2256

Expected behavior

It should link to the right place - probably https://github.com/meta-llama/llama-stack/blob/main/docs/source/getting_started/index.md
@simonw
Copy link
Author

simonw commented Dec 15, 2024

README has the same problem:

llama-stack/README.md

Line 141 in cb8a28c

* [Jupyter notebook](./docs/getting_started.ipynb) to walk-through how to use simple text and vision inference llama_stack_client APIs

@simonw simonw changed the title 404 link on llama.com getting_started.ipynb link on llama.com is a 404 Dec 15, 2024
@iamarunbrahma iamarunbrahma mentioned this issue Dec 16, 2024
Merged
6 tasks
ashwinb pushed a commit that referenced this issue Dec 17, 2024
@iamarunbrahma
docs: Update getting_started.ipynb link to correct jupyter notebook p…
10eb31b 
…ath in README.md (#636)

# What does this PR do?

This PR fixes a broken link in the README.md that was causing a 404
error. The link to `getting_started.ipynb` was pointing to a
non-existent file. Updated it to point to the correct notebook
`Llama_Stack_Building_AI_Applications.ipynb` which contains the
walk-through for text and vision inference llama_stack_client APIs.

- [x] Addresses issue (#633 )

## Test Plan

1. Verified that the new notebook path exists:
   ```bash
   ls docs/notebooks/Llama_Stack_Building_AI_Applications.ipynb
   ```

2. Verified the notebook content contains text and vision inference
examples by:
   - Checking the notebook contents
- Confirming the presence of vision models like
Llama-3.2-11B-Vision-Instruct
   - Verifying llama_stack_client API usage examples


## Before submitting

- [x] This PR fixes a typo or improves the docs (you can dismiss the
other checks if that's the case).
- [x] Ran pre-commit to handle lint / formatting issues.
- [x] Read the [contributor
guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md),
Pull Request section.
- [x] Updated relevant documentation.
- [ ] Wrote necessary unit or integration tests (N/A - documentation
change only).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw