-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Picture> element does not work with flickity. #161
Comments
Thanks for this feature request. Add a 👍 reaction to this issue if you would like to see Flickity add support for |
+1 |
2 similar comments
+1 |
+1 |
+1. Some hopefully helpful numbers: Picture support is currently at 45% global. Safari 9 is support still TBD, but srcset/sizes have been in nightlies for awhile. IE Edge supports srcset with density descriptors, and |
+1 |
10 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1. It's sad to see that almost a year later this is still not a thing, especially as browser support is getting better even without polyfill. |
The past year has been very un-sad for Flickity and Metafizzy in general. I realize it can be a bummer when the one issue you're looking for is unresolved. Please consider the larger picture. |
@marzepani see #172 for srcset |
So, one year later, is this coming in v2? Not trolling, it's a serious question. |
Sorry no plans to support this feature currently. |
Cheers man, making due with the lazyload feature to speed things up instead. Awesome work all around! |
It worked, sort of. |
I'd be keen to see this implemented, as I'd like to able to make |
Hi, Flickity is great and I really like it. Isn't it time to reconsider this feature request? It's almost end of 2018 and Internet Explorer is almost a thing of past now. Like @drewm I'd like to use |
Thanks why I'm here, I just saw this Ticket is much newer so I just want to connect my POST which I just made some mins ago to here. I think its not much to do to achive a fully integrates |
I think the best solution to this would be: using the The good part about it: it can lazyLoad the whole Would look like this:
The TAG-Name just have to be replaced when ever you want to load its content! I just made it! Here is my DEMO - (change height to see its working) |
@desandro may you have a look at this. Would be awesome if you could implement this into Slickity as I use it with |
I just made another DEMO which works with vanilla JavaScript and DeepCopy. Both now also have a delay in the function of 500ms to make it more visible to the eye and better noticeable in the Dev-Console under Network.
Notice: the DOM/HTML now decides what and how many are lazyloaded, not Now the first two are getting loaded instantly and the other should get converted short befor coming to the viewport. At least thats how I think it would work. ANd yes I know IDs should be unique, we can change them to classes but for the demo its working |
With WebP browser support now > 50% US and > 80% global, and file size savings in the neighborhood of 30% compared to lossy JPEG, Google is increasingly pushing for use of WebP in its site auditing tools. (See https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fflickity.metafizzy.co under "Serve images in next-gen formats".) I'm sure none of this is news to you @desandro, but I'm currently wrestling with how to to improve some site audit scores on a site that uses Flickity everywhere (I originally built the site and am very vocal in my support for this wonderful library!) yet when it came time for a different developer to add a slider around a set of massive hero images that use I saw the old issue (#172) where the writer/maintainer of Lazysizes (@aFarkas — another excellent project!) helpfully chimed in on a combo method for using it with Flickity, but his demos aren't up-to-date with Flickity v2 and no longer work. The Chrome team is working on browser-native image lazyloading, but the feature remains behind an Experimental Feature flag. I know that I have some options between Lazysizes and several of the comments/suggestions above, but I'm writing all this out to ask for at least a recommended way forward to be documented for Flickity. Thank you for your consideration. 🙇 |
Hi - I'd like to add a comment supporting the request for this feature. Page speed and mobile optimization is and is important to us and our clients, and responsive picture elements are very helpful to achieve that goal. I have been using this library for years and I like it very much. I would greatly like to see it continue being awesome. |
+1 |
This is a very small merge request that fixes the This feature is important as srcset attribute cannot handle pixel density and viewport width at the same time. |
Flickity v3 support Thanks for your patience with this one. I still need to update documentation. |
@desandro - this is great, thank you. |
It would be amazing to feature responsive images in the slide. e.g. square images for mobile and full images for desktop. Is this already supported or something you might have thought about?
The text was updated successfully, but these errors were encountered: