Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CAPI to 1.8.x #1964

Open
tuminoid opened this issue Sep 16, 2024 · 2 comments · May be fixed by #1967
Open

Bump CAPI to 1.8.x #1964

tuminoid opened this issue Sep 16, 2024 · 2 comments · May be fixed by #1967
Assignees
@kashifest
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

Bump CAPI dependency to 1.8.x.

CAPI bumps brings alone CR 0.18.x and k8s.io/* v0.30.x, and it needs some migration steps.

INFO [runner] linters took 18.924923958s with stages: goanalysis_metalinter: 18.844396632s 
createVM/main.go:12:9: could not import github.com/metal3-io/baremetal-operator/test/e2e (-: # github.com/metal3-io/baremetal-operator/test/e2e
e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)) (typecheck)
	bmoe2e "github.com/metal3-io/baremetal-operator/test/e2e"
	       ^
e2e/bmc.go:1: : # github.com/metal3-io/baremetal-operator/test/e2e [github.com/metal3-io/baremetal-operator/test/e2e.test]
e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply) (typecheck)

Also running osv-scanner vs bumped packages has:

ailed to run code analysis (govulncheck) on '/home/tumi/git/metal3-io/baremetal-operator/test/go.mod' because govulncheck: loading packages: 
There are errors with the provided package patterns:

/home/tumi/git/metal3-io/baremetal-operator/test/e2e/cert_manager.go:34:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
/home/tumi/git/metal3-io/baremetal-operator/test/e2e/common.go:348:21: clusterProxy.Apply undefined (type framework.ClusterProxy has no field or method Apply)
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:38:60: undefined: libvirt.StoragePool
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:40:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:102:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:166:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:211:23: undefined: libvirt.NewConnect
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:249:11: undefined: libvirt.NETWORK_UPDATE_COMMAND_ADD_LAST
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:250:11: undefined: libvirt.NETWORK_SECTION_IP_DHCP_HOST
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:253:11: undefined: libvirt.NETWORK_UPDATE_AFFECT_LIVE
/home/tumi/git/metal3-io/baremetal-operator/test/createVM/main.go:253:46: undefined: libvirt.NETWORK_UPDATE_AFFECT_CONFIG
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Sep 16, 2024
@tuminoid
Copy link
Member Author

Dependabot has example bumps, which cannot merge and should autoclose with a proper fix PR.

@kashifest
Copy link
Member

/assign @kashifest
/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Sep 16, 2024
@kashifest kashifest linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifest kashifest

Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Bump controller runtime to v0.18.5 and CAPI to v1.8.3 Nordix/baremetal-operator
3 participants
@tuminoid @kashifest @metal3-io-bot