Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump the k8s.io/* deps to v0.28.12 #1853

Closed
wants to merge 1 commit into from
Closed

🌱 Bump the k8s.io/* deps to v0.28.12 #1853

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2024 •
edited
Loading

Bumps the kubernetes group with 2 updates in the / directory: k8s.io/api and k8s.io/apiextensions-apiserver.
Bumps the kubernetes group with 2 updates in the /api directory: k8s.io/api and k8s.io/apiextensions-apiserver.
Bumps the kubernetes group with 2 updates in the /hack/tools directory: k8s.io/api and k8s.io/apiextensions-apiserver.
Bumps the kubernetes group with 1 update in the /test directory: k8s.io/api.

Updates k8s.io/api from 0.28.11 to 0.28.12

Commits

Updates k8s.io/apiextensions-apiserver from 0.28.11 to 0.28.12

Commits

Updates k8s.io/apimachinery from 0.28.11 to 0.28.12

Commits

Updates k8s.io/client-go from 0.28.11 to 0.28.12

Commits

Updates k8s.io/component-base from 0.28.11 to 0.28.12

Commits

Updates k8s.io/api from 0.28.11 to 0.28.12

Commits

Updates k8s.io/apiextensions-apiserver from 0.28.11 to 0.28.12

Commits

Updates k8s.io/apimachinery from 0.28.11 to 0.28.12

Commits

Updates k8s.io/client-go from 0.28.11 to 0.28.12

Commits

Updates k8s.io/component-base from 0.28.11 to 0.28.12

Commits

Updates k8s.io/api from 0.28.0 to 0.28.12

Commits

Updates k8s.io/apiextensions-apiserver from 0.28.0 to 0.28.12

Commits

Updates k8s.io/apimachinery from 0.28.0 to 0.28.12

Commits

Updates k8s.io/code-generator from 0.28.11 to 0.28.12

Commits

Updates k8s.io/api from 0.28.11 to 0.28.12

Commits

Updates k8s.io/apiextensions-apiserver from 0.28.11 to 0.29.3

Commits

Updates k8s.io/apimachinery from 0.28.11 to 0.29.3

Commits

Updates k8s.io/client-go from 0.28.11 to 0.29.3

Commits

Updates k8s.io/component-base from 0.28.11 to 0.29.3

Commits

Updates k8s.io/klog/v2 from 2.100.1 to 2.110.1

Release notes

Sourced from k8s.io/klog/v2's releases.

Prepare klog release for Kubernetes v1.29 (Take 1)

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.100.1...v2.110.1

Commits
  • e3f75b8 Merge pull request #384 from pohly/slog
  • 44eadc3 add slog support
  • cc856bb update to logr 1.3.0
  • 02e7b69 Merge pull request #391 from pohly/with-name-output
  • 009a04a output: handle WithName like zapr does
  • b588475 Merge pull request #380 from pohly/golangci-lint-action
  • 1a0dfc5 github: run golangci-lint via action
  • ef25537 fix revive issues
  • edee20c Merge pull request #392 from pohly/promote-experimental
  • 18cdd3a promote experimental code to stable
  • Additional commits viewable in compare view

Updates k8s.io/utils from 0.0.0-20230406110748-d93618cff8a2 to 0.0.0-20231127182322-b307cd553661

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 24, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboukhalfa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2024
Rozzii
Rozzii reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @adilGhaffarDev @mboukhalfa @mquhuy
WDYT? is that downgrade okay that I have highlighted?

hack/tools/go.sum
@@ -613,8 +613,8 @@ rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20230510161459-7571f4b9a942 h1:hFD347lSM3XkuHzQYmZzna9ibtrgaw8qGNPI3eEsrVo=
sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20230510161459-7571f4b9a942/go.mod h1:B6HLcvOy2S1qq2eWOFm9xepiKPMIc8Z9OXSPsnUDaR4=
sigs.k8s.io/controller-tools v0.13.0 h1:NfrvuZ4bxyolhDBt/rCZhDnx3M2hzlhgo5n3Iv2RykI=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downgrade, I wonder if this is ok like this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay now I see it is actually un-buildable, should we rebase or cancel this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to ask Dependabot to recreate the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we can cancel it or rebase it, re-creating I am not sure.

@Rozzii
Copy link
Member

Rozzii commented Jul 31, 2024

@dependabot rebase

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 31, 2024

Looks like this PR is already up-to-date with release-1.6! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Rozzii
Copy link
Member

Rozzii commented Jul 31, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/release-1.6/kubernetes-2cf1d29a25 branch from 06b57d7 to f726cd1 Compare July 31, 2024 10:00
tuminoid
tuminoid reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
It is downgrading and upgrading packages versus the rules.

hack/tools/go.mod
sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20230510161459-7571f4b9a942
sigs.k8s.io/controller-tools v0.13.0
sigs.k8s.io/controller-tools v0.12.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downgrade isn't cool.

test/go.mod
sigs.k8s.io/cluster-api v1.6.7
sigs.k8s.io/cluster-api/test v1.6.7
sigs.k8s.io/controller-runtime v0.16.6
k8s.io/api v0.29.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bump from 0.28 to 0.29 is not cool either.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@tuminoid
Copy link
Member

tuminoid commented Aug 5, 2024

/retitle 🌱 Bump the k8s.io/* deps to v0.28.12
For the release notes.

@metal3-io-bot metal3-io-bot changed the title 🌱 Bump the kubernetes group across 4 directories with 8 updates 🌱 Bump the k8s.io/* deps to v0.28.12 Aug 5, 2024
@tuminoid
Copy link
Member

tuminoid commented Aug 6, 2024

Let's try recreation once more, as other bumps PRs have merged.

@dependabot recreate

@dependabot
🌱 Bump the kubernetes group across 4 directories with 8 updates
966de6b 
Bumps the kubernetes group with 2 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver).
Bumps the kubernetes group with 2 updates in the /api directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver).
Bumps the kubernetes group with 2 updates in the /hack/tools directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver).
Bumps the kubernetes group with 1 update in the /test directory: [k8s.io/api](https://github.com/kubernetes/api).


Updates `k8s.io/api` from 0.28.11 to 0.28.12
- [Commits](kubernetes/api@v0.28.11...v0.28.12)

Updates `k8s.io/apiextensions-apiserver` from 0.28.11 to 0.28.12
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.11...v0.28.12)

Updates `k8s.io/apimachinery` from 0.28.11 to 0.28.12
- [Commits](kubernetes/apimachinery@v0.28.11...v0.28.12)

Updates `k8s.io/client-go` from 0.28.11 to 0.28.12
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.11...v0.28.12)

Updates `k8s.io/component-base` from 0.28.11 to 0.28.12
- [Commits](kubernetes/component-base@v0.28.11...v0.28.12)

Updates `k8s.io/api` from 0.28.11 to 0.28.12
- [Commits](kubernetes/api@v0.28.11...v0.28.12)

Updates `k8s.io/apiextensions-apiserver` from 0.28.11 to 0.28.12
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.11...v0.28.12)

Updates `k8s.io/apimachinery` from 0.28.11 to 0.28.12
- [Commits](kubernetes/apimachinery@v0.28.11...v0.28.12)

Updates `k8s.io/client-go` from 0.28.11 to 0.28.12
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.11...v0.28.12)

Updates `k8s.io/component-base` from 0.28.11 to 0.28.12
- [Commits](kubernetes/component-base@v0.28.11...v0.28.12)

Updates `k8s.io/api` from 0.28.0 to 0.28.12
- [Commits](kubernetes/api@v0.28.11...v0.28.12)

Updates `k8s.io/apiextensions-apiserver` from 0.28.0 to 0.28.12
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.11...v0.28.12)

Updates `k8s.io/apimachinery` from 0.28.0 to 0.28.12
- [Commits](kubernetes/apimachinery@v0.28.11...v0.28.12)

Updates `k8s.io/code-generator` from 0.28.11 to 0.28.12
- [Commits](kubernetes/code-generator@v0.28.11...v0.28.12)

Updates `k8s.io/api` from 0.28.11 to 0.28.12
- [Commits](kubernetes/api@v0.28.11...v0.28.12)

Updates `k8s.io/apiextensions-apiserver` from 0.28.11 to 0.29.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.11...v0.28.12)

Updates `k8s.io/apimachinery` from 0.28.11 to 0.29.3
- [Commits](kubernetes/apimachinery@v0.28.11...v0.28.12)

Updates `k8s.io/client-go` from 0.28.11 to 0.29.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.11...v0.28.12)

Updates `k8s.io/component-base` from 0.28.11 to 0.29.3
- [Commits](kubernetes/component-base@v0.28.11...v0.28.12)

Updates `k8s.io/klog/v2` from 2.100.1 to 2.110.1
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.100.1...v2.110.1)

Updates `k8s.io/utils` from 0.0.0-20230406110748-d93618cff8a2 to 0.0.0-20231127182322-b307cd553661
- [Commits](https://github.com/kubernetes/utils/commits)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/api
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/code-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/klog/v2
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/release-1.6/kubernetes-2cf1d29a25 branch from f726cd1 to 966de6b Compare August 6, 2024 05:55
@kashifest
Copy link
Member

@dependabot close

@dependabot dependabot bot closed this Aug 6, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 6, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/go_modules/release-1.6/kubernetes-2cf1d29a25 branch August 6, 2024 18:22
@kashifest
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this Aug 6, 2024
@dependabot dependabot bot restored the dependabot/go_modules/release-1.6/kubernetes-2cf1d29a25 branch August 6, 2024 18:23
@metal3-io-bot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test 966de6b link true /test test
gomod 966de6b link true /test gomod
build 966de6b link true /test build
generate 966de6b link true /test generate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tuminoid tuminoid mentioned this pull request Aug 7, 2024
Merged
tuminoid
tuminoid reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependabot PR is getting worse and worse, so I made manual one to do the bump without side-effect: #1873

/hold
We keep this open, and it should autoclose as verification when the above PR is merged.

test/go.mod
k8s.io/apimachinery v0.29.3
k8s.io/client-go v0.29.3
k8s.io/utils v0.0.0-20231127182322-b307cd553661
sigs.k8s.io/cluster-api v1.7.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is also CAPI bump to 1.7

test/go.mod
k8s.io/utils v0.0.0-20231127182322-b307cd553661
sigs.k8s.io/cluster-api v1.7.4
sigs.k8s.io/cluster-api/test v1.7.4
sigs.k8s.io/controller-runtime v0.17.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and CR bump.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2024

Looks like these dependencies are no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Aug 7, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/release-1.6/kubernetes-2cf1d29a25 branch August 7, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metal3-io-bot @Rozzii @tuminoid @kashifest @adilGhaffarDev