Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete function in file distributor must consider namespace before deleting #229

Open
mortenwh opened this issue Sep 24, 2024 · 2 comments
Assignees

Comments

@mortenwh
Copy link
Collaborator

Currently, the file distributor deletes datasets only based on the uuid. If a dataset from staging, with namespace no.met.staging, has been mistakenly added, the original one (with namespace no.met) will be erroneously deleted when cleaning up. This can happen, since insert will add the dataset to csw and solr, even if the namespace is incorrect (see #228; but it will not be added in the file dist).

@charlienegri
Copy link
Contributor

charlienegri commented Sep 27, 2024

@Teddy-1000 I think I got it wrong and I addressed this in https://github.com/metno/discovery-metadata-catalog-ingestor/blob/namespace_checks/dmci/api/app.py#L237,
I can take both issues if you are ok, or then I also can drop this branch if you already worked on this issue, no stress

@Teddy-1000
Copy link

@Teddy-1000 I think I got it wrong and I addressed this in https://github.com/metno/discovery-metadata-catalog-ingestor/blob/namespace_checks/dmci/api/app.py#L237, I can take both issues if you are ok, or then I also can drop this branch if you already worked on this issue, no stress

I have not started, go ahead with your branch. @charlienegri

@charlienegri charlienegri mentioned this issue Sep 27, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants