Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map filter and number of datasets in collection #44

Open
lhmarsden opened this issue Sep 10, 2024 · 2 comments
Open

Map filter and number of datasets in collection #44

lhmarsden opened this issue Sep 10, 2024 · 2 comments

Comments

@lhmarsden
Copy link

I have observed this issue on both SIOS and the NBS staging area, so I believe it is probably an issue on all configurations.

When one does a map filter, the number that states the number of datasets in a collection does not change. So if the map filter includes only 4 out of the 10 datasets in the collection, the button would continue to state that there are 10 datasets.

This could be misleading. It should say either 4 or perhaps 4 out of 10.

@steingod
Copy link
Collaborator

There is an issue with the search interface in general for the time being. Not sure if it is a consequence of some upgrades, but think @magnarem is checking these issues.

@magnarem
Copy link
Collaborator

@lhmarsden . I have now fixed this issue and updated nbs-staging.met.no and metsis-staging.met.no for testing this.

The question is what we do with the child button if no children are found within a collection when using the map filter.
Now the child button will be gone if there are no children within the collection matching the map filter. but the parent might still show if the full_text string or date in the search matches, it is not that easy to remove parents from the main search when counting the children..but it might be possible.

I do not know what is the best solution. maybe @steingod have some comments.

I see three possible solutions.

  1. just show the parent, since the parent matched the search, but no children within this collection matched, so the "Child"-button will not be displayed.
  2. Display the child-button with all possible children. (Then it really does not take the filtering into account)
  3. Try to remove that parent from the main search, so the record does not show. (this can be a bit difficult to solve, but should be possible.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants