Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aeroval's time colocation is strange when colocate_time=True is set #867

Open
jgriesfeller opened this issue May 28, 2023 · 1 comment
Open
Labels
invalid This doesn't seem right

Comments

@jgriesfeller
Copy link
Member

dataset is missing years 2014 to 2016:

aerocom3_ADV_LTS_v1_od550aer_Column_1995_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_1996_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_1997_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_1998_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_1999_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2000_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2001_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2002_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2003_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2004_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2005_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2006_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2007_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2008_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2009_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2010_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2011_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2012_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2017_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2018_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2019_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2020_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2021_daily.nc
aerocom3_ADV_LTS_v1_od550aer_Column_2022_daily.nc

but with colocate_time=True there's values during the missing time frame anyway:
image

with colocate_time=False the gap is there as expected:
image

I wonder if the time colocation just uses the nearest neighbour regardless how "near" that neighbour is.

@lewisblake
Copy link
Member

Similar related issues: #736, #755, #762

@lewisblake lewisblake added the invalid This doesn't seem right label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants