Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aerovaldb profiles arguments issue #1317

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix aerovaldb profiles arguments issue #1317

merged 1 commit into from
Aug 19, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Aug 19, 2024 •
edited
Loading

Change Summary

Fix aerovaldb profiles arguments issue and bumps aerovaldb version to fix profiles-data-being-written-to-wrong-location issue[1].

Related issue number

closes #1311

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Additional context

  1. Wrong template used for profiles aerovaldb#66

@thorbjoernl thorbjoernl added bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract labels Aug 19, 2024
@thorbjoernl thorbjoernl added this to the m2024-09 milestone Aug 19, 2024
@thorbjoernl thorbjoernl self-assigned this Aug 19, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (89b9921) to head (5e1b98f).
Report is 5 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/aeroval/coldatatojson_engine.py 0.00% 3 Missing ⚠️
pyaerocom/aeroval/experiment_output.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           main-dev    #1317      +/-   ##
============================================
- Coverage     79.00%   78.99%   -0.01%     
============================================
  Files           136      136              
  Lines         20797    20798       +1     
============================================
  Hits          16430    16430              
- Misses         4367     4368       +1
Flag Coverage Δ
unittests 78.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake
Copy link
Member

I will check out this branch and test it

@thorbjoernl thorbjoernl marked this pull request as ready for review August 19, 2024 10:01
lewisblake
lewisblake approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@lewisblake lewisblake merged commit f73e411 into main-dev Aug 19, 2024
6 of 8 checks passed
@lewisblake lewisblake deleted the fix-profiles-issue branch August 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisblake lewisblake lewisblake approved these changes

Assignees

@thorbjoernl thorbjoernl

Labels
bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract
Projects
None yet
Milestone
m2024-09
Development

Successfully merging this pull request may close these issues.

aerovaldb get_profiles
2 participants
@thorbjoernl @lewisblake