Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider if current architecture is good enough #16

Closed
ways opened this issue Nov 20, 2024 · 1 comment · Fixed by #27
Closed

Consider if current architecture is good enough #16

ways opened this issue Nov 20, 2024 · 1 comment · Fixed by #27

Comments

@ways
Copy link
Collaborator

ways commented Nov 20, 2024

Somewhat connected to #8

Running the validator via pytest/schemathesis has it's limitations. Perhaps some tests (anything openapi related) should be done like that, and some should be done in normal python code? I can't find any good ways to create unittests for the code run by pytest and decorators. And it's hard to get output to look the way I want.

@ways
Copy link
Collaborator Author

ways commented Nov 21, 2024

A suggestion, which might lead to a confusing code base, but perhaps better user experience?

  • Args handled, logs set up
  • Run basic web tests, checking we get content from /, /conformance, /api etc.
  • Check contents of json received. Validate everything follows EDR, rodeo profile
  • If all so far is successfull, run schemathesis checks.

This would lead to lots simpler, human readable output in the beginning of developing a service. Get all the simple stuff out of the way before moving on to more advanced checks.

@ways ways linked a pull request Nov 25, 2024 that will close this issue
@ways ways closed this as completed in #27 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant