You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running pydeps against Cylc master, without filtering out dependencies, I noticed that it reported zero cyclic dependency for Cylc, but one for isodatetime.
Executing pydeps --show-cycles isodatetime against latest version in master for isodatetime reports:
This is because (1) isodatetime.data depends on the (2) cylc.dumpers. (2) isodatetime.dumper's depends on the (3) isodatetime.parsers (this dependency is imported only in get_time_zone). And (3) isodatetime.parsers depends on (1) isodatetime.data.
This normally indicates that the design of the dependency between classes/categories can be simplified. Allowing easier maintenance (e.g. refactor, move classes to different packages, and so on).
The text was updated successfully, but these errors were encountered:
Running
pydeps
against Cylcmaster
, without filtering out dependencies, I noticed that it reported zero cyclic dependency for Cylc, but one forisodatetime
.Executing
pydeps --show-cycles isodatetime
against latest version in master forisodatetime
reports:This is because (1)
isodatetime.data
depends on the (2)cylc.dumpers
. (2)isodatetime.dumper
's depends on the (3)isodatetime.parsers
(this dependency is imported only inget_time_zone
). And (3)isodatetime.parsers
depends on (1)isodatetime.data
.This normally indicates that the design of the dependency between classes/categories can be simplified. Allowing easier maintenance (e.g. refactor, move classes to different packages, and so on).
The text was updated successfully, but these errors were encountered: